feat(cdk/portal): add directives support to ComponentPortal#33142
Open
chintankavathia wants to merge 1 commit intoangular:mainfrom
Open
feat(cdk/portal): add directives support to ComponentPortal#33142chintankavathia wants to merge 1 commit intoangular:mainfrom
chintankavathia wants to merge 1 commit intoangular:mainfrom
Conversation
chintankavathia
force-pushed
the
fix/component-portal-directives
branch
2 times, most recently
from
d12a48f to
db53a21
Compare
Added a `directives` property to `ComponentPortal` that gets passed through to `createComponent` in both `DomPortalOutlet` and `CdkPortalOutlet`. This allows applying directives to dynamically created components via portals. Closes angular#33141
chintankavathia
force-pushed
the
fix/component-portal-directives
branch
from
db53a21 to
d8caf17
Compare
chintankavathia
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a
directivesproperty toComponentPortalthat gets passed through tocreateComponentin bothDomPortalOutletandCdkPortalOutlet. This allows applying directives to dynamically created components via portals.Closes #33141